|
|
|
Adding ip info to all errors can be tedious. Can you be specific on which type of errors you concerns about?
As I mentioned in the Description section, all login errors should be displayed IP.
We have a shared account for some teams to use for some other services that can be automatically trigger build.
But one of them forgot to update the password when it was changed to lock the account due to wrong login too many times. We need this IP information to promptly process it, so IP should be displayed with an account in any case of error login. QB 8.0.49 is now released to include ip info for these failed login attempts.
I tried with QB8, Qb12, QB13. When I try to login on SignInPage, the only thing I received was "com.pmease.quickbuild.web.page.SignInPage - Error authenticating user.
om.pmease.quickbuild.AuthenticationException: Error authenticating user 'abc.cde': User not found or password incorrect." In SecurityHelper.java
if (ip != null) { throw new AuthenticationException("Error authenticating user '" + correctedUserName + "' from ip '" + ip + "': User not found or password incorrect."); } else { throw new AuthenticationException("Error authenticating user '" + correctedUserName + "': User not found or password incorrect."); } And in SignInPage.java User user = SecurityHelper.authenticate(userName, password, null); ==> Obviously IP has not been displayed in this case. |
Do you think it is reasonable to always display the user with IP in the Error log? I need that information to manage the user's login management.
However, it does not display fully on QB8. Let me know your opinion.