History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: QB-3416
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Assignee: Unassigned
Reporter: Alexey Shumkin
Votes: 0
Watchers: 0

If you were logged in you would be able to see more operations.

Response to GitLab hook request is HTTP 200 OK if no webhook found for configuration

Created: 04/Jul/19 11:38 AM   Updated: 16/Jul/19 01:28 AM
Component/s: None
Affects Version/s: 9.0.10
Fix Version/s: 9.0.13

Original Estimate: Unknown Remaining Estimate: Unknown Time Spent: Unknown
Operating System Linux 4.4.0-139-generic, amd64
JVM OpenJDK 64-Bit Server VM 1.8.0_111, Oracle Corporation
QuickBuild Version 9.0.10 - Sat May 18 10:49:01 UTC 2019

 Description  « Hide
QB responses with the error text (by its meaning) but with the HTTP 200 OK status code

Steps to reproduce:
1. Set up a GitLab project to send webhook to a QB server
2. Test this setup in GitLab with an appropriate button "Test"
3. See that the request succeeds but it details shows that it is not

  Response headers:
    Connection: close
    Date: Thu, 04 Jul 2019 11:25:16 GMT
    Content-Type: text/plain
    Vary: Accept-Encoding, User-Agent
    Server: Jetty(9.4.14.v20181114)

  Response body:
    Gitlab webhook setting not defined

and, expectedly, a build is not run..

I suppose QB server should give some 4xx error status code in such cases to simplify diagnostics.

 All   Comments   Work Log   Change History      Sort Order:
There are no comments yet on this issue.