History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: QB-2522
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Unassigned
Reporter: John Szakmeister
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
QuickBuild

Don't redirect on a bad url.

Created: 26/Aug/15 09:02 AM   Updated: 05/Sep/15 01:04 PM
Component/s: None
Affects Version/s: 6.0.26
Fix Version/s: 6.0.27

Original Estimate: Unknown Remaining Estimate: Unknown Time Spent: Unknown


 Description  « Hide
I've had a couple of developers complain about this, as well as running into it myself. If you try to access an invalid url--for instance, the referenced build no longer exists--then when trying to reference that build, you get redirected. This is bad behavior from an HTTP perspective. It should be a 404 error with no redirect as anything else confuses tools.

For instance, "curl -f 'http://neovim-qb.szakmeister.net/build/1000'" appears to succeed, but it should really be a failure. See "curl -f 'http://www.szakmeister.net/bogus-url/'" as an example.

 All   Comments   Work Log   Change History      Sort Order:
John Szakmeister [05/Sep/15 01:04 PM]
6.0.27 doesn't really fix the issue. The problem was that QB was disguising a bad url by redirecting to an error page, when it really should be a 404 error. You got rid of the redirect, but the real problem still exists: QB is returning success when it means failure. The curl command above should result in an error when referencing an invalid page.