Robin Shen [05/Aug/15 01:33 AM] This is a limitation QB calculates changes based on branch, but in Gerrit changes, there is no reliable branch to calculate changes inside.

Daniel Kossakowski [05/Aug/15 07:22 AM] Thanks for your reply Robin. As far as I know Gerrit by default makes diffs between last commit from source branch and current refs branch. I think you are able to get basic information about change (like ID or commit ID?) while QB detects it and is able to set Verified label. IDK how does your function work, but I think you can take change revision for example using GET /changes/{change-id}. Or you can get directly changes set for specified review using Get Patch or Get Diff calls from API. https://review.typo3.org/Documentation/rest-api-changes.html#get-diff

Robin Shen [05/Aug/15 10:39 PM] Thanks for the info Daniel. Ideally for any patch set, we can run "git log" between commit id of the target branch and commit id of the patch set, to get the changes. However inside QB changes have to be calculated between builds, and when build against gerrit changes, there is no build carrying commit id of the target branch to cause changes not being able to be calculated under QB's current change calculation mechanism. Yes this issue is caused by QB's approach of change calculation mechanism (in order to make things simpler for a bunch of SCMs), and it is not a slight change to adjust the common change calcuation right now. I will keep this issue opened as a backlog so that we can take this into consideration when we decide to improve the common change calculation mechanism.