[#QB-2368] Pull request fails to build...

QuickBuild

Pull request fails to build...

Created: 14/Mar/15 09:35 AM Updated: 16/Mar/15 08:58 AM

Component/s:

None

Affects Version/s:

6.0.9

Fix Version/s:

None

Original Estimate:

Unknown

Remaining Estimate:

Unknown

Time Spent:

Unknown

Description

« Hide

As you guys know, I've been getting a QuickBuild server setup for the Neovim project. I wanted to run a build against a specific pull request, but it failed with a 404 exception (perhaps because it hit the quota for api usage). I tried re-running the build, but it failed because there were no changes. So I changed the build condition to always build (there is no schedule at the moment), and it *still* failed because there were no changes. This seems like a bug.

All

Comments

Work Log

Change History

Sort Order:

[ Permlink | « Hide ]

John Szakmeister [14/Mar/15 09:42 AM]

I should add that my concern is being able to re-run failed builds because I've screwed up (the steps aren't correct) or something else has failed (reaching quota limit against GitHub, etc.).

[ Permlink | « Hide ]

John Szakmeister [14/Mar/15 09:54 AM]

I believe this same bug is keeping me from running builds manually against pull requests one at a time (I'd like to test some manually before setting it loose on 6+ hours of builds).

[ Permlink | « Hide ]

Robin Shen [15/Mar/15 01:08 AM]

To avoid queueing many build requests (even if there are no changes), QB has a flag "Queue Changed Branches Only" in advanced setting of configuration. You may turn off it to have QB queue pull request builds so that it goes through normal change detection and build firing process, and then you can run the build manually to force build of your open pull requests.

[ Permlink | « Hide ]

Robin Shen [15/Mar/15 01:10 AM]

While keep that flag turned off, you can also manually build any pull requests by specifying pull request id on GitHub repo definition.

[ Permlink | « Hide ]

John Szakmeister [15/Mar/15 11:05 AM]

Oh wow. Why do you have both the build condition and this other flag? That's confusing. :-( Thank you for the explanation Robin.

[ Permlink | « Hide ]

Robin Shen [16/Mar/15 12:32 AM]

Previously QB may queue a lot of build requests if there are a lot of open pull requests there even if there are updates in these pull requests, and QB can only realize that there are no changes at change detection phase. With this flag, we can bypass the change detection phase if there are no updates to these pull requests.

This is actually an improvement requested by several other customers using GitHub integration heavily.

[ Permlink | « Hide ]

John Szakmeister [16/Mar/15 08:58 AM]

That makes sense. I can see having a lot of builds queued up being an issue. It might be worth a note in the UI stating that QB won't even look at the build condition if no other change has been detected though. And what was most surprising is that I asked it to look at other branches with each request, but once it took its snapshot, it refused to look at anything else. I may have asked it to look at pull requests, but only a single one. The fact that it applied it across the aboard was really confusing--and that's the part that felt really buggy. Perhaps there's not a better way though.

Thanks for the explanation!