History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: QB-3578
Type: Improvement Improvement
Status: Reopened Reopened
Priority: Minor Minor
Assignee: Unassigned
Reporter: Robin Shen
Votes: 3
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
QuickBuild

Send status reason text along with status code in pre-queue evaluation response

Created: 25/May/20 11:12 PM   Updated: 26/Nov/20 02:40 AM
Component/s: None
Affects Version/s: 10.0.13
Fix Version/s: 10.0.16

Original Estimate: Unknown Remaining Estimate: Unknown Time Spent: Unknown


 All   Comments   Work Log   Change History      Sort Order:
Dong Van Thang [01/Jun/20 06:38 AM]
Hope you will implement it soon.
Thank you!

Robin Shen [01/Jun/20 11:38 PM]
Should be available by end of this week

Change by Steve Luo [05/Jun/20 12:16 PM]
Field Original Value New Value
Status Open [ 1 ] Resolved [ 5 ]
Assignee Robin Shen [ robinshine ]
Resolution Fixed [ 1 ]

Change by Steve Luo [05/Jun/20 12:16 PM]
Fix Version/s 10.0.16 [ 11972 ]

Robin Shen [05/Jun/20 12:20 PM]
This has now been fixed in 10.0.16. To send status reason together with status code, return a string in pre-queue script something like below:

"500:Some special server error"

The number before colon is status code, and text after colon represents status reason.

Since there is no standard way to return a customized status text in http procotol, the status reason is carried in http response via header "statusReason"

Dong Van Thang [08/Jun/20 08:26 AM]
Oh, Sorry, why don't we return text message via body????
like return Response.status(Integer.parseInt(beforeColon)).entity(StringUtils.substringAfter(result.getRejectReason(), ":")).build();? Thank you!

Robin Shen [08/Jun/20 11:10 PM]
Because it will be silently dropped, as body is not expected to convey any messages in case there are http errors.

Dong Van Thang [24/Jul/20 04:47 AM]
Dear QuickBuild team,

After we have done implement QB10, we realize that:

1. Many users do not check header contents.

2. lt is more common to give reject reason in the body.

So, we would like you to improve this problem, return text message via response's body.
What do you think so? Please kindly give me your idea!

Thank you so much!

Robin Shen [24/Jul/20 10:59 PM]
I am reopening this issue and will investigate further.

Change by Robin Shen [24/Jul/20 10:59 PM]
Resolution Fixed [ 1 ]
Status Resolved [ 5 ] Reopened [ 4 ]

Dong Van Thang [27/Jul/20 02:55 AM]
Thank you so much!

Change by Steve Luo [28/Aug/20 02:03 AM]
Status Reopened [ 4 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]

Dong Van Thang [28/Aug/20 02:22 AM]
Thank you so much for this improvement.

Robin Shen [28/Aug/20 04:04 AM]
Sorry this is a mistake. It is not implemented yet.

Change by Robin Shen [28/Aug/20 04:04 AM]
Resolution Fixed [ 1 ]
Status Resolved [ 5 ] Reopened [ 4 ]

Change by Steve Luo [07/Sep/20 04:52 PM]
Status Reopened [ 4 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]

Change by Steve Luo [07/Sep/20 04:52 PM]
Resolution Fixed [ 1 ]
Status Resolved [ 5 ] Reopened [ 4 ]

DPI SVMC [26/Nov/20 02:40 AM]
Please consider about this improvement again. Thank you!