History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: QB-3569
Type: Improvement Improvement
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Unassigned
Reporter: Michal Tyminski
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
QuickBuild

Change Git reference repository argument to --reference-if-able

Created: 07/May/20 04:08 PM   Updated: 09/May/20 12:06 AM
Component/s: None
Affects Version/s: None
Fix Version/s: 10.0.13

Original Estimate: Unknown Remaining Estimate: Unknown Time Spent: Unknown


 Description  « Hide
Please consider using "--reference-if-able" argument instead of "--reference". Advantage of this method is that it can handle non-existing path situation.
It would be very helpful in situations when for some reason reference repository is not available on build agent so it would continue with remote repo saving build from failure by extending resource usage.

Git documentation: https://git-scm.com/docs/git-clone#Documentation/git-clone.txt---reference-if-ableltrepositorygt

file: com.pmease.quickbuild.plugin.scm.git/src/com/pmease/quickbuild/plugin/scm/git/GitCli.java

File refRepo = new File(refRepoPath);
if (!refRepo.exists()) {
    throw new QuickbuildException("Reference repository path [" + refRepoPath + "] doesn't exist");
} else if (!refRepo.isDirectory()) {
    throw new QuickbuildException("Reference repository path [" + refRepoPath + "] should be a git directory");
} else {
    command.setLine("--reference").setValue(refRepoPath);
}


 All   Comments   Work Log   Change History      Sort Order:
Change by Robin Shen [08/May/20 12:34 AM]
Field Original Value New Value
Assignee Robin Shen [ robinshine ] Steve Luo [ steve ]

Change by Steve Luo [09/May/20 12:06 AM]
Status Open [ 1 ] Resolved [ 5 ]
Assignee Steve Luo [ steve ]
Resolution Fixed [ 1 ]

Change by Steve Luo [09/May/20 12:06 AM]
Fix Version/s 10.0.13 [ 11957 ]