| << Back to previous view |
|
[QB-2522] Don't redirect on a bad url.
|
|
| Status: | Resolved |
| Project: | QuickBuild |
| Component/s: | None |
| Affects Version/s: | 6.0.26 |
| Fix Version/s: | 6.0.27 |
| Type: | Bug | Priority: | Major |
| Reporter: | John Szakmeister | Assigned To: | Unassigned |
| Resolution: | Fixed | Votes: | 0 |
| Remaining Estimate: | Unknown | Time Spent: | Unknown |
| Original Estimate: | Unknown | ||
| Description |
|
I've had a couple of developers complain about this, as well as running into it myself. If you try to access an invalid url--for instance, the referenced build no longer exists--then when trying to reference that build, you get redirected. This is bad behavior from an HTTP perspective. It should be a 404 error with no redirect as anything else confuses tools.
For instance, "curl -f 'http://neovim-qb.szakmeister.net/build/1000'" appears to succeed, but it should really be a failure. See "curl -f 'http://www.szakmeister.net/bogus-url/'" as an example. |
| Comments |
| Comment by John Szakmeister [ 05/Sep/15 01:04 PM ] |
| 6.0.27 doesn't really fix the issue. The problem was that QB was disguising a bad url by redirecting to an error page, when it really should be a 404 error. You got rid of the redirect, but the real problem still exists: QB is returning success when it means failure. The curl command above should result in an error when referencing an invalid page. |