<< Back to previous view

[QB-2389] migrate.sh has an issue
Created: 26/Mar/15  Updated: 01/Apr/15

Status: Closed
Project: QuickBuild
Component/s: None
Affects Version/s: 6.0.10
Fix Version/s: None

Type: Bug Priority: Major
Reporter: Phong Trinh Assigned To: Robin Shen
Resolution: Fixed Votes: 0
Remaining Estimate: Unknown Time Spent: Unknown
Original Estimate: Unknown
Environment: QB 6.0.10 - Linux Machine


 Description   
 Hi Robin,

  We compiled the source code of release 6.0.10 and tried to migrate my system to this version. However, we found that the migrate.sh has some junk hidden characters such as [dos]. This file was not generated by the compile, and it was copied form the source. Can you look into the issue of this file?

 Thank you in advance,

-Phong

 Comments   
Comment by Robin Shen [ 27/Mar/15 12:56 AM ]
Please call dos2unix to convert the script to unix version.
Comment by Phong Trinh [ 27/Mar/15 02:06 PM ]
I think this migrate.sh file should be in Unix version, since migrate.bat is for Windows. Do you think it is an issue with the source?
Comment by Phong Trinh [ 27/Mar/15 02:27 PM ]
I am concerned about the source, not only this file, since this file should be already in Unix version. Can you please double check the source to ensure that it has no issue?
Comment by Robin Shen [ 28/Mar/15 02:21 AM ]
We develop on Windows, and edit this file on Windows. Our package script will convert it to Unix when packaging the product. You may do the same.
Comment by Phong Trinh [ 30/Mar/15 01:49 PM ]
 Thank you for promptly response.
 Per your previous comment, the source has not issue. Since the file was developed on Windows platform, we need to convert it to Unix format. We will do as your suggestion and keep you informed.

 Thank you again.
Phong Trinh
Comment by Phong Trinh [ 30/Mar/15 02:35 PM ]
 We learned that we need to convert a number of files in the build to Unix version, not only migrate.sh file. There are chance, we may miss some of them. So I think we need to create builld/package in Unix version using the package script. Can you give us this script for building Unix version and maybe its process?
Comment by Robin Shen [ 30/Mar/15 11:29 PM ]
We build QB package on Unix (although do daily development on Windows), so various .sh files checked out from our git server is of unix format already. At your side, you may add an extra step in QB build script (build/build.xml) to call dos2unix to convert various .sh to unix format.
Comment by Phong Trinh [ 01/Apr/15 08:03 PM ]
We found that the issue was with QB. When QB synchronized the source from Perforce down to the build machine, by default (QB option: End Line = Local), it converted the files to version of machine platform. Since the build machine was Windows platform; therefore, Perforce converted files to Windows version. We changed End Line = unix, and the build is fine.

 Thanks,
Generated at Mon May 20 23:57:31 UTC 2024 using JIRA 189.