<< Back to previous view

[QB-2139] Be able to record changes for repositories not being used for checkout
Created: 24/Jul/14  Updated: 21/Dec/14

Status: Resolved
Project: QuickBuild
Component/s: None
Affects Version/s: 5.1.31
Fix Version/s: 6.0.0

Type: Improvement Priority: Major
Reporter: Robin Shen Assigned To: Robin Shen
Resolution: Fixed Votes: 1
Remaining Estimate: Unknown Time Spent: Unknown
Original Estimate: Unknown


 Comments   
Comment by AlSt [ 11/Aug/14 12:27 PM ]
I think the most convenient solution would be to have a "Record Changes" step.
Comment by Robin Shen [ 12/Aug/14 01:35 AM ]
We thought about this, but this makes things a little bit complicated as in normal cases you will need to add two steps to do checkout and get changes.
Comment by Maikel vd Hurk [ 12/Aug/14 07:55 AM ]
Does this improvement will be implemented? As we would like to track as well SCM changes without need of adding a checkout step pointing to repository.
Comment by Robin Shen [ 13/Aug/14 01:27 AM ]
Yes, we'd like to deliver this feature into next major release - QB 5.2
Comment by AlSt [ 08/Sep/14 12:09 PM ]
Also the script we are using now for getting the changes (as stated here: http://forum.pmease.com/viewtopic.php?f=1&t=3208#p12352) has one major weakness. In getReferencedRepositories() the repository does not get considered as referenced because it is a script step and not a RepositoryStep.

Is there any estimate when 5.2 gets released?
Comment by Robin Shen [ 09/Sep/14 12:27 AM ]
QB 5.2 will be released at end of this year together with other major enhancements.
Comment by AlSt [ 09/Sep/14 01:10 PM ]
Just one question to understand that better:

"We thought about this, but this makes things a little bit complicated as in normal cases you will need to add two steps to do checkout and get changes. "

Why would that need to add two steps for checkout and get changes?

Checkout step would be the same as before (Checkout and record changes). Just new Record Changes RepositoryStep to record only the changes which is also a RepositoryStep (so it can be found by getReferencedRepositories())

So in my opinion checkout without changes does not make sense, but changes without checkout would make sense.

And there is also the isChangesRecorded() flag which would be set by both steps and also checked by both it will be done only once.
Comment by Robin Shen [ 10/Sep/14 12:30 AM ]
In other cases, user does not want to retrieve changes when doing checkout. For instance, when a configuration is used to build for multiple branches. The changes since previous build might be meaningless if they belong to different branches. So separating changes recording from checkout step is our initial thought.
Generated at Fri May 17 12:24:02 UTC 2024 using JIRA 189.